Conversation
Added support for the new DRY (dehumidification) mode that the Quilt API now returns. This is a new mode available on the Quilt system. - Updated HVACMode enum in enums.py to include DRY = 8 - Updated proto definition in quilt_hds.proto - Regenerated protobuf files
There was a problem hiding this comment.
Pull request overview
This PR updates the client’s domain and wire enums to recognize the Quilt API’s new dehumidification mode (DRY), ensuring snapshots and other proto-derived objects can represent the mode without failing enum conversion.
Changes:
- Add
DRY = 8to the publicHVACModeenum. - Extend the
HVACModeprotobuf enum withHVAC_MODE_DRY = 8. - Regenerate protobuf Python/stub outputs to include the new enum value.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/quilt_hp/models/enums.py | Adds HVACMode.DRY = 8 to the public Python enum surface. |
| proto/cleaned/quilt_hds.proto | Updates the source proto enum to include HVAC_MODE_DRY = 8. |
| src/quilt_hp/_proto/quilt_hds_pb2.py | Regenerated protobuf runtime module reflecting the new enum value. |
| src/quilt_hp/_proto/quilt_hds_pb2.pyi | Regenerated type stubs reflecting the new enum value. |
Files not reviewed (1)
- src/quilt_hp/_proto/quilt_hds_pb2.py: Language not supported
| FAN = 5 | ||
| FALLBACK_AUTO = 6 | ||
| FALLBACK_OFF = 7 | ||
| DRY = 8 |
| FAN = 5 | ||
| FALLBACK_AUTO = 6 | ||
| FALLBACK_OFF = 7 | ||
| DRY = 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the new DRY (dehumidification) mode that the Quilt API now returns. This is a new mode available on the Quilt system.